Skip to content

Fix intermitent lint error on types package #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Jul 22, 2025

Add another nolint check to pass lint checks that have been failing intermittently recently.

@bjee19 bjee19 requested a review from a team as a code owner July 22, 2025 21:10
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (225aab4) to head (4d4f749).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3652      +/-   ##
==========================================
+ Coverage   86.93%   87.05%   +0.12%     
==========================================
  Files         126      127       +1     
  Lines       15350    15579     +229     
  Branches        0       62      +62     
==========================================
+ Hits        13344    13562     +218     
- Misses       1847     1858      +11     
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a weird issue, so because the linter sometimes has a problem with the package name, we need a no lint for that, but inconsistently so we need a no lint for our no lint?!

I really hope this works 🤦🏼‍♀️ 😅

@bjee19 bjee19 enabled auto-merge (squash) July 23, 2025 16:17
@bjee19 bjee19 merged commit 77c5bbc into main Jul 23, 2025
42 of 43 checks passed
@bjee19 bjee19 deleted the chore/fix-lint-error branch July 23, 2025 16:41
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 23, 2025
@bjee19
Copy link
Contributor Author

bjee19 commented Jul 23, 2025

What a weird issue, so because the linter sometimes has a problem with the package name, we need a no lint for that, but inconsistently so we need a no lint for our no lint?!

Yea such a weird and annoying thing, hopefully we don't keep running into issues with our linter like this. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants