Skip to content

Proposed rewrite to "Creating Microsoft Azure Virtual Machines for NGINX Open Source and F5 NGINX Plus" #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

jawfu-M
Copy link

@jawfu-M jawfu-M commented May 27, 2025

NOTE: this is a rewrite only. No technical changes.

The original documentation was slightly difficult to read and follow. It had complex sentences and paragraphs that scored 14 on the Hemmingway app. Some constructs were conflicting or confusing, which took longer to understand.

I improved the document’s readability and clarity, making it accessible to a wider, non-expert audience. Here’s how:

  • Rewrote complex paragraphs graded at 14 to achieve Grade 6 clarity without losing meaning
  • Shortened lengthy sentences to improve readability and flow
  • Converted a dense, difficult step into a clear, bulleted list of actionable tasks
  • Replaced overly technical words with simpler language
  • Clarified technical concepts to make them understandable for non-specialist readers
  • Shifted tone from passive to active voice to increase directness

Testing: I used the Hemmingway app to confirm readability and studied the terms individually to ensure they were all updated.

  • [ ✔️] I have read the contributing guidelines
  • [ ✔️] I have signed the F5 Contributor License Agreement (CLA)
  • [✔️] I have rebased my branch onto main
  • [✔️ ] I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • [✔️ ] I have ensured that the commit messages adhere to Conventional Commits
  • [ ✔️] I have ensured that documentation content adheres to the style guide
  • [ ✔️] If the change involves potentially sensitive changes1, I have assessed the possible impact
  • [ ✔️] If applicable, I have added tests that prove my fix is effective or that my feature works
  • [ ✔️] I have ensured that existing tests pass after adding my changes
  • [✔️ ] If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@jawfu-M jawfu-M requested a review from a team as a code owner May 27, 2025 17:46
@jawfu-M
Copy link
Author

jawfu-M commented Jul 2, 2025

Hello 👋 @y82
I wanted to kindly follow up on this pull request. Please let me know if there's anything I can do to help with the review process. Thank you!

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of LGTM: I made a large amount of suggestions to fix formatting issues introduced by the PR.

Most of them related to inline links being turned into production URLs and raw HTML being added to the Markdown text.

I'm happy to give an approval on the basis of my edit suggestions being implemented, but @y82 is the final call on if this can be merged or not.


<a href="/nginx/images/azure-create-vm-networking.png"><img src="/nginx/images/azure-create-vm-networking.png" alt="screenshot of 'Networking' tab on Azure 'Create a virtual machine' page" width="1024" height="718" class="aligncenter size-full wp-image-64994" style="border:2px solid #666666; padding:2px; margin:2px;" /></a>
When this guide was first published, the hourly cost for the six VMs was only $0.008. And this costlier than VMs with basic IP addresses. For current pricing, see the [Microsoft documentation](https://azure.microsoft.com/en-us/pricing/details/ip-addresses/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within the reading flow, this sentence sticks out like a sore thumb.

@ADubhlaoich ADubhlaoich requested a review from y82 July 3, 2025 15:14
jawfu-M and others added 16 commits July 3, 2025 23:47
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
@jawfu-M
Copy link
Author

jawfu-M commented Jul 4, 2025

Sort of LGTM: I made a large amount of suggestions to fix formatting issues introduced by the PR.

Most of them related to inline links being turned into production URLs and raw HTML being added to the Markdown text.

I'm happy to give an approval on the basis of my edit suggestions being implemented, but @y82 is the final call on if this can be merged or not.

Hi @ADubhlaoich 👋

Thank you for your thoughtful suggestions! I’ve committed all the changes and will closely review the rest of the file to catch any similar issues.

Really appreciate your patience as I get up to speed (Whew!). Your feedback has been incredibly helpful. Please let me know if you spot anything else.

Thank you so much once again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants