Skip to content

replaced instances of e.g. and i.e. with English equivalents #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

replaced instances of e.g. and i.e. with English equivalents #565

merged 1 commit into from
May 19, 2025

Conversation

travisamartin
Copy link
Contributor

Proposed changes

This PR replaces instances of "e.g.," and "i.e.," with "for exampmle" and "that is," respectively -- per the NGINX style guide.

@travisamartin travisamartin requested a review from a team as a code owner May 19, 2025 19:47
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim NGINX Instance Manager product/ngf Issues related to NGINX Gateway Fabric product/agent NGINX Agent product/amplify NGINX Amplify (EOS product) product/controller NGINX Controller (EOS product) product/nap-dos NGINX App Protect DOS product/nap-waf NGINX App Protect WAF product/nms NGINX Management Suite (EOS product) labels May 19, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/565/

mjang
mjang approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases, "such as" sounds better to me than "for example"

But in all cases, "for example" is IMO acceptable -- and helps us in our move away from Latinisms

@travisamartin travisamartin self-assigned this May 19, 2025
@travisamartin travisamartin enabled auto-merge (squash) May 19, 2025 20:11
@travisamartin travisamartin merged commit a58c68a into main May 19, 2025
9 checks passed
@travisamartin travisamartin deleted the style-no-eg-ie branch May 19, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjang mjang mjang approved these changes

@JTorreG JTorreG JTorreG approved these changes

Assignees

@travisamartin travisamartin

Labels
documentation Improvements or additions to documentation product/agent NGINX Agent product/amplify NGINX Amplify (EOS product) product/controller NGINX Controller (EOS product) product/nap-dos NGINX App Protect DOS product/nap-waf NGINX App Protect WAF product/ngf Issues related to NGINX Gateway Fabric product/nim NGINX Instance Manager product/nms NGINX Management Suite (EOS product)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@travisamartin @mjang @JTorreG