Skip to content

361 httptraffic #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025
Merged

361 httptraffic #517

merged 6 commits into from
May 6, 2025

Conversation

jaypolansky1
Copy link
Contributor

@jaypolansky1 jaypolansky1 commented May 4, 2025

Proposed changes

Problem: The page contained many long sentences and clauses that could be simplified to enhance readability.

Solution: I split up longer sentences into smaller sentences, and I also changed a list separated by commas into bullet points.

Testing: N/A

Please focus on (optional): I focused my edits on the top portion of the document except for the bullet point section toward the end of the document.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #361

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@jaypolansky1 jaypolansky1 requested a review from a team as a code owner May 4, 2025 22:41
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) labels May 4, 2025
Copy link

github-actions bot commented May 4, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


2 out of 3 committers have signed the CLA.
✅ (jaypolansky1)[https://github.com/jaypolansky1]
✅ (mjang)[https://github.com/mjang]
❌ @“jaypolansky1”
“jaypolansky1” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@jaypolansky1
Copy link
Contributor Author

jaypolansky1 commented May 4, 2025

I have hereby read the F5 CLA and agree to its terms

@jaypolansky1
Copy link
Contributor Author

recheck

@jaypolansky1
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@jaypolansky1
Copy link
Contributor Author

recheck

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contributions!

While we're at the conference, I'd love to chat about this PR. We're doing an unconference session tomorrow (Tuesday) at 8:30 am

@mjang
Copy link
Contributor

mjang commented May 6, 2025

recheck

@mjang
Copy link
Contributor

mjang commented May 6, 2025

Required contributors have signed the CLA

@mjang mjang merged commit 63f5490 into nginx:main May 6, 2025
5 of 6 checks passed
@jaypolansky1
Copy link
Contributor Author

Thanks so much for your contributions!

While we're at the conference, I'd love to chat about this PR. We're doing an unconference session tomorrow (Tuesday) at 8:30 am

Of course! It was a pleasure and a great opportunity to learn a bit about Git!

I would love to chat about this PR. I will likely not be able to make the unconference session. Would it be ok if I found you sometime throughout the day and potentially coordinate through Slack?

@mjang mjang added the community label May 6, 2025
@jaypolansky1
Copy link
Contributor Author

Hi @mjang! I am heading over to Revolution Hall in a few. Are you in the library where the unconference sessions are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review NGINX Plus Admin Guide: Securing HTTP Traffic to Upstream Servers
2 participants