Skip to content

Update app-gateway-uwsgi-django.md #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

Update app-gateway-uwsgi-django.md #514

merged 4 commits into from
May 6, 2025

Conversation

ryreed
Copy link
Contributor

@ryreed ryreed commented May 4, 2025

A few text updates for clarity and gerund use.

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@ryreed ryreed requested a review from a team as a code owner May 4, 2025 21:39
Copy link

github-actions bot commented May 4, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) labels May 4, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Congratulations on your first contribution.

@mjang
Copy link
Contributor

mjang commented May 5, 2025

Actually, @ryreed , could you type the following line into a comment?

I have hereby read the F5 CLA and agree to its terms

By typing in that line, you're accepting our "Contributor License Agreement" which allows us to keep our repository as open source. Thanks so much!

@mjang mjang self-requested a review May 5, 2025 21:51
@mjang
Copy link
Contributor

mjang commented May 6, 2025

Thanks so much for your contribution! We love all improvements to our documentation. I've made some suggestions, and welcome discussion. While I'd like changes, I've approved your PR! Congratulations! We'll have an unconference session where we can discuss Tuesday at 8:30 am. Thanks!

@ryreed
Copy link
Contributor Author

ryreed commented May 6, 2025

I have hereby read the F5 CLA and agree to its terms

@mjang mjang merged commit 2f9aa1c into nginx:main May 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants