Skip to content

Simplify NIM helm Instructions - Update deploy-using-helm.md #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

mkingst
Copy link
Contributor

@mkingst mkingst commented Jan 28, 2025

Removed sections about pulling images and pushing to private registry. It's no longer necessary and we should encourage users to use the official registry.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@mkingst mkingst requested a review from a team as a code owner January 28, 2025 21:43
@mkingst
Copy link
Contributor Author

mkingst commented Jan 28, 2025

I have hereby read the F5 CLA and agree to its terms

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/130/

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one "typo-level" comment; I'll push -- and since this is approval #2, will proceed with merge.

@mjang mjang enabled auto-merge (squash) February 3, 2025 16:03
@mjang mjang merged commit b41f5ff into main Feb 3, 2025
5 checks passed
@mjang mjang deleted the mkingst-simplify-helm-instructions branch February 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants