Remove some subjective extensions, add .gitignore #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfy133
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Although I use all 3 regularly I can see the logic:
- Indent colouring - most of the languages we use don't care about indentation (except tools)
- Spell check - we don't have a specific language requirement so sort of useless for standardisation
But I would argue to keep the TODO tree
- Because we use a LOT of TODOs in many places in the template so it helps discover ability of these
|
Yup - also indent colouring annoys me with hanging indentation in nextflow, which looks super ugly. Happy to keep TODO tree. I use that one quite a bit, just removed it to be consistent but can add it back again. |
|
@jfy133 updated ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself routinely disabling some extensions that we have in the extension pack, the indentation colouration primarily.
I think that we should keep the extension pack to only the really essential ones, so I've removed these and moved them to a section of the readme where they're still recommended but just no longer installed by default.
x-ref nextflow training: nextflow-io/training#539 (comment)