Skip to content

BAM_MARKDUPLICATES_PICARD => incorrect take docs #8413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
nick-youngblut opened this issue May 7, 2025 · 4 comments
Closed
2 tasks done

BAM_MARKDUPLICATES_PICARD => incorrect take docs #8413

nick-youngblut opened this issue May 7, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@nick-youngblut
Copy link
Contributor

Have you checked the docs?

Description of the bug

Current:

workflow BAM_MARKDUPLICATES_PICARD {

    take:
    ch_bam   // channel: [ val(meta), path(bam) ]
    ch_fasta // channel: [ path(fasta) ]
    ch_fai   // channel: [ path(fai) ]

However, the input for PICARD_MARKDUPLICATES is:

    input:
    tuple val(meta), path(bam)
    tuple val(meta2), path(fasta)
    tuple val(meta3), path(fai)

...so the docs should be:

    take:
    ch_bam   // channel: [ val(meta), path(bam) ]
    ch_fasta // channel: [ val(meta), path(fasta) ]
    ch_fai   // channel: [ val(meta), path(fai) ]

Command used and terminal output

Relevant files

No response

System information

No response

@nick-youngblut nick-youngblut added the bug Something isn't working label May 7, 2025
@nick-youngblut nick-youngblut changed the title AM_MARKDUPLICATES_PICARD => incorrect input docs BAM_MARKDUPLICATES_PICARD => incorrect input docs May 7, 2025
@nick-youngblut nick-youngblut changed the title BAM_MARKDUPLICATES_PICARD => incorrect input docs BAM_MARKDUPLICATES_PICARD => incorrect take docs May 7, 2025
@SPPearce
Copy link
Contributor

SPPearce commented May 8, 2025

Feel free to make a PR to fix this.

@nick-youngblut
Copy link
Contributor Author

It's an addition of just a few characters, so I was thinking that this issue would be wrapped into a larger "docs update" PR, but sure, I can create the PR.

@SPPearce
Copy link
Contributor

SPPearce commented May 9, 2025

Unless you think there are more changes that need updating, might as well get it done now and then it actually happens.

@nick-youngblut
Copy link
Contributor Author

nick-youngblut commented May 10, 2025

Done: #8431.
I'm looking forward for these little PRs to be fully AI automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants