-
Notifications
You must be signed in to change notification settings - Fork 213
Local devcontainers enablement #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
aa6dbdd
db07194
dcc3367
d4fe3e3
21d5d6f
7ce3608
267622a
595168b
a29a5e4
56e300c
1f79ad7
5a07633
7ff6464
3488dc4
cb6169f
957ab43
460de86
f3e3bd4
8d69d56
30fcf73
e33405d
80f656a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../Dockerfile |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"name": "nextflow-training (codespaces)", | ||
|
||
// Update this to pin the release tag before release | ||
"image": "ghcr.io/nextflow-io/training:latest", | ||
// Uncomment this and comment "image" when testing Dockerfile changes | ||
// "build": { "dockerfile": "Dockerfile", "context": ".." }, | ||
|
||
"features": { | ||
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": { | ||
"version": "latest" | ||
} | ||
}, | ||
"workspaceFolder": "/workspaces/training", | ||
"workspaceMount": "source=${localWorkspaceFolder},target=/workspaces/training,type=bind", // Used for local devcontainers, ignored in Codespaces. | ||
pinin4fjords marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"remoteEnv": { | ||
"NXF_HOME": "/workspaces/.nextflow", | ||
"HOST_PROJECT_PATH": "/workspaces/training" // Codespaces and local devcontainers will both work with this. | ||
}, | ||
"postCreateCommand": "nextflow -version; if [ -z \"$CODESPACES\" ]; then echo \"Devcontainers Development\"; else echo \"Codespaces Development\"; fi", | ||
pinin4fjords marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// Configure tool-specific properties. | ||
"customizations": { | ||
// Configure properties specific to VS Code. | ||
"vscode": { | ||
// Set *default* container specific settings.json values on container create. | ||
"settings": { | ||
"python.defaultInterpreterPath": "/opt/conda/bin/python" | ||
}, | ||
// Add the IDs of extensions you want installed when the container is created. | ||
"extensions": [ | ||
"ms-python.python", | ||
"ms-python.vscode-pylance", | ||
"nf-core.nf-core-extensionpack", // nf-core recommended extensions | ||
"nextflow.nextflow", // Nextflow VS Code extension | ||
"codezombiech.gitignore", // Language support for .gitignore files | ||
"cssho.vscode-svgviewer" // SVG viewer | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can simplify these - I'd also like to remove a couple of the more subjective packages from the nf-core extension pack (rainbow indentation, TODO tree, code spell checker). I find myself disabling these each time in devcontainers, which is annoying. We can do this in a separate PR, as needs upstream changes to the nf-core extension pack first. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
ewels marked this conversation as resolved.
Show resolved
Hide resolved
|
||
] | ||
} | ||
}, | ||
"remoteUser": "root" | ||
} |
ewels marked this conversation as resolved.
Show resolved
Hide resolved
|
This file was deleted.
ewels marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
./codespaces/devcontainer.json |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../Dockerfile |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
{ | ||
"name": "nextflow-training (local)", | ||
|
||
// Update this to pin the release tag before release | ||
"image": "ghcr.io/nextflow-io/training:latest", | ||
// Uncomment this and comment "image" when testing Dockerfile changes | ||
// "build": { "dockerfile": "Dockerfile", "context": ".." }, | ||
|
||
"features": { | ||
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": { | ||
"version": "latest" | ||
} | ||
}, | ||
"workspaceFolder": "${localWorkspaceFolder}", | ||
"workspaceMount": "source=${localWorkspaceFolder},target=${localWorkspaceFolder},type=bind", | ||
"remoteEnv": { | ||
"NXF_HOME": "/workspaces/training/.nextflow", | ||
"HOST_PROJECT_PATH": "/workspaces/training" | ||
}, | ||
"postCreateCommand": "sudo mkdir -p /workspaces && sudo ln -s ${localWorkspaceFolder} /workspaces/training && if [ -z \"$CODESPACES\" ]; then echo \"Local Development\"; else echo \"Codespaces Development\"; fi", | ||
pinin4fjords marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"customizations": { | ||
// Configure properties specific to VS Code. | ||
"vscode": { | ||
// Set *default* container specific settings.json values on container create. | ||
"settings": { | ||
"python.defaultInterpreterPath": "/opt/conda/bin/python", | ||
"terminal.integrated.cwd": "/workspaces/training", | ||
"terminal.integrated.defaultLocation": "workspace" | ||
}, | ||
// Add the IDs of extensions you want installed when the container is created. | ||
ewels marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"extensions": [ | ||
"ms-python.python", | ||
"ms-python.vscode-pylance", | ||
"nf-core.nf-core-extensionpack", // nf-core recommended extensions | ||
"nextflow.nextflow", // Nextflow VS Code extension | ||
"codezombiech.gitignore", // Language support for .gitignore files | ||
"cssho.vscode-svgviewer" // SVG viewer | ||
ewels marked this conversation as resolved.
Show resolved
Hide resolved
|
||
] | ||
} | ||
}, | ||
"remoteUser": "root" | ||
} |
Uh oh!
There was an error while loading. Please reload this page.