Skip to content

Minor fixes to parts 3, 4, and 5 of Hello Nextflow #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 19, 2025
Merged

Minor fixes to parts 3, 4, and 5 of Hello Nextflow #514

merged 7 commits into from
Feb 19, 2025

Conversation

mribeirodantas
Copy link
Member

@mribeirodantas mribeirodantas commented Feb 19, 2025 •
edited
Loading

  • Fix capitalization of GitHub and Gitpod
  • Minor fixes to Part 3
  • Part 4 is very good, but a bit short.
  • Minor fixes to Part 5

@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit e1eea98
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/67b5c696e2112600085816fd
😎 Deploy Preview https://deploy-preview-514--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ewels
ewels previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a quick scan on my phone

vdauwera
vdauwera previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@vdauwera vdauwera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good catches, just a couple of minor change requests to keep things simple. Feel free to merge once you've made the changes.

@mribeirodantas mribeirodantas dismissed stale reviews from vdauwera and ewels via ce0d18f February 19, 2025 11:51
@mribeirodantas
Add suggestions from Geraldine and Phil
e1eea98 
- Remove mention of fair threading
- Remove mention of multi-channel
- Convert absolute to relative link
@mribeirodantas mribeirodantas changed the title Minor fixes to part 3 and 4 of Hello Nextflow Minor fixes to part 3, 4 and 5 of Hello Nextflow Feb 19, 2025
@mribeirodantas mribeirodantas changed the title Minor fixes to part 3, 4 and 5 of Hello Nextflow Minor fixes to parts 3, 4, and 5 of Hello Nextflow Feb 19, 2025
@mribeirodantas mribeirodantas merged commit a43f170 into master Feb 19, 2025
8 checks passed
@mribeirodantas mribeirodantas deleted the minor_fixes branch February 19, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdauwera vdauwera Awaiting requested review from vdauwera

@ewels ewels Awaiting requested review from ewels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mribeirodantas @ewels @vdauwera