Skip to content

Cherry-pick to master: Goodbye GitPod, hello GitHub Codespaces #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 18, 2025

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 17, 2025

Used git cherry-pick to lift changes in #506 over to be based on the master branch instead.

Had to merge a bunch of conflicts manually - some version of #506 will still be needed for the new materials on that branch. Can update once this is merged and apply.

Still to do:

  • All the file paths 🫠
  • Translations
  • Find any stragglers I missed

Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 9070df7
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/67b3c4784c79cc00088fedbb
😎 Deploy Preview https://deploy-preview-507--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ewels
Copy link
Member Author

ewels commented Feb 17, 2025

Note that because of how we build the container, I think the file path /home/gitpod/.nextflow/ is still valid for now 😅

@vdauwera
Copy link
Collaborator

Tested most of the Hello Nextflow exercises, fixed a few remaining issues and updated setup instructions to recommend using a 4-core machine.

@vdauwera vdauwera self-requested a review February 17, 2025 23:26
Copy link
Collaborator

@vdauwera vdauwera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to go to me. Not merging myself bc if anything goes wrong I wouldn't know how to fix it, but anyone who's up early and feels good about it should feel free to merge.

@ewels ewels merged commit e913bcb into nextflow-io:master Feb 18, 2025
7 checks passed
@ewels ewels deleted the codespaces-2.1 branch February 18, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants