-
Notifications
You must be signed in to change notification settings - Fork 212
Port Adam's nf-test to new structure #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step toward evolving Hello Nextflow to be more modular. Just content moves and stub creation (not updated content yet except some rough chopping where bits are getting split up).
work in progress
Much more step by step demonstration of how channels work + overall logical progression should make more sense now
Mainly to make it more clear what we're learning from sections 3 and 4
This one is really completely trivial now (no more nf-core style directory nesting). Remaining TODOs are just copy pasting the finalized code.
A few TODOs remaining, mainly updating console outputs etc
Text improvements Co-authored-by: Jonathan Manning <jonathan.manning@seqera.io>
Co-authored-by: Jonathan Manning <jonathan.manning@seqera.io>
A few updates left but this is almost complete
After reconsidering the review comments, realized that it is ok and actually better to introduce variable inputs and params in Hello World. Getting them out of the way before Channels is actually helpful. The trick is to not get bogged down in details about value versus queue channels. The rest is a bit streamlined as a results. Also made Operators intro more explicit. Also got started on some cleanup of the code files
- Space after view {...} - Config tweaks - demo to test profile - param json before profiles - Also renamed Run Nextflow to Nextflow Run
remove example where we ask participants to executing a run that we know will fail.
…lo-nextflow' into gvda-streamline-hello-nextflow
Required some adaptations to config
Moved non-maintained materials to 'other' directory, commented out the future courses that aren't ready yet, and updated index pages and navs accordingly. Also turned off alt languages because the translations are too far out of date, to the point of being misleading. We'll bring back translations when we've had a chance to refresh them. (They will still be accessible via the v2.0 of the portal)
Anticipation having multiple domain-specific mini-courses, want to keep them organized to minimize clutter
Ultimately would like the top nav to point to this instead of the Genomics specifically but I'm not sure how that interacts with the course navigation setup so not messing with that yet
Configuration and testing sections are placeholders and should not be included in the portal at this time.
These two need a bit more work to fit properly
Mainly small text fixes Co-authored-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.