Skip to content

Apply automatic formatting with the vscode extension #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Nov 6, 2024

This PR applies automatic formatting with the vscode linting formatter. Since everyone's vscode will automatically do this, it makes sense to get ahead of it.

To do:

  • Update all markdown documentation to match

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit e4038f6
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/672bc1c860a3dd00084869c7
😎 Deploy Preview https://deploy-preview-439--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mribeirodantas
Copy link
Member

mribeirodantas commented Nov 6, 2024

I think it's a bit early to do this. The formatter has been getting some feedback recently and I believe it will have changes in the near future. For indenting, for example, I think we should stick to Harshil's style.

You also probably noticed the repeated \ at new lines, which is a known bug (it's been fixed for the next release). So I think it's worth it waiting a bit.

@kenibrewer
Copy link
Member

kenibrewer commented Nov 6, 2024 via email

@adamrtalbot
Copy link
Collaborator Author

Are there any downsides to applying what the formatter recommends right now and then switching later for the new formatted version?

Message ID: @.***>

I guess it's more work? but well I'm afraid maintaining this repo is always going to be work, no getting away from that 😅.

We should keep it up to date with the vscode extension so that participants don't have surprising code "fixes" appearing when they hit ctrl+s, it shouldn't be that hard.

@vdauwera
Copy link
Collaborator

Oof we're going to have to redo all of this now that we've merged the new version, aren't we...

It seems like a lot of it is indentation, which rolls up to #517

Going to close this since resolving the merge conflicts would be more work than just doing it from scratch, but I agree we should definitely align on the vscode linting for these conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants