Add support for official Nextflow parameters meta schema #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewels
reviewed
Feb 19, 2025
| private Pattern uriPattern = Pattern.compile('^#/(\\d*)?/?(.*)$') | ||
| // TODO Change the base URL once the meta schema has been officially released | ||
| final private Map<String,String> supportedCustomParameterDrafts = [ | ||
| "https://github.com/nextflow-io/schema-spec/raw/refs/heads/main/parameters_meta_schema.json": "/schemas/parameters/1.0/parameters_meta_schema.json" |
There was a problem hiding this comment.
This has to be versioned surely? main will be a moving target.
There was a problem hiding this comment.
Yes that's what the TODO statement is for :). I can't put a versioned URL there as it doesn't exist yet
mirpedrol
reviewed
Aug 28, 2025
| ## Nested parameters | ||
|
|
||
| !!! example "New feature in v2.1.0" | ||
| !!! example "Not supported in by the official [Nextflow specifications](https://github.com/nextflow-io/schema-spec/blob/main/parameters_meta_schema.json)" |
There was a problem hiding this comment.
We could make it a warning and use admonitions so it stands out more
There was a problem hiding this comment.
Good idea! I'll update this PR fully once the schema has been released
We decided to drop this because it does basically the same as specifying your schema draft (2020-12 vs nextflow-schema) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new features:
validation.modethat can be set tolimitedto ensure compatibility with nf-core tooling, Seqera platform and othersThis PR should not be merged before a tagged version of the schema has been released