Replace drop/list/view commands with pipelines command
#5966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
One consideration might be to align the |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
|
Let's postpone this, post 25.04. There's no hurry |
|
At that point we might as well not do it, we'll likely have CLI v2 by then |
|
Yeah, let's just do this in CLI v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5959
This PR moves the
drop,list, andviewcommands into a singlepipelinescommand:listis too similar tolint, easy to misspellI was originally going to move
cloneandpullas well, but I'm not sure if there's a clean way to support CLI options for these subcommands with JCommander. I refactored the main three commands to not have any extra options, but I don't think I can do this forcloneandpull. Also, moving thepullcommand might be more disruptive anyway.Long-term, I think we could introduce a CLI v2 called
nfwith (1) GNU-style options, (2) picocli over JCommander, and (3) a refactored command tree. So for now I'm happy to just merge this change as a short-term improvement.