fix: ensure fonts are shipped #3006
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
susnux
commented
Oct 28, 2025
susnux
commented
- resolves feat: only provide fonts which are available (shipped by us) #2956 (comment)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/backport to stable32 |
|
/backport to stable31 |
| # SPDX-License-Identifier: AGPL-3.0-or-later | ||
| css/fonts/ | ||
|
|
||
| # We do not ship the Roboto font files (only needed for Cypress) - but we need to ship the other font files |
There was a problem hiding this comment.
If they are only needed for tests, it would be great to have them somehow separate, as they don't belong to the source code.
There was a problem hiding this comment.
This is the normal asset directory so they will get written to this directory anyways.
They are used to force once font in Cypress tests to allow visual regression tests
There was a problem hiding this comment.
Sure, but can they be shipped differently, since they are only used for tests?
skjnldsv
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.