fix: generate favourite icon without imagick svg support

[SebastianKrupinski]

• Resolves: # client ticket

Summary

Before

Custom favourite icon was only generate when imagick svg support was turned on

After

Custom favourite is generate even when imagick svg support is not present, as long a a supported image format is used

Testing

1. Make sure Imagick is installed
2. In Administrative settings -> Themes -> Update the logo and favicon use PNG to start (this should reset the image cache)
3. Log out then log back in (This should generate new favicon visible in the browser tab by the tab headeing)
4. Repeat test with SVG enable and svg logo and favicon

TODO

• Tests

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[szaimen]

@SebastianKrupinski does this address #36607?

[SebastianKrupinski]

@SebastianKrupinski does this address #36607?

No, it still uses imagick, but it no longer requires imagick svg support, to generate icons, the icons where generated as png's anyway, it only requires imagick png support and a png logo. But it will generate themed svg icons also

If we want to generate themed icons, we have to either limit the input formats to png, and we can use another library like php-gd, or stick with imagick as its the only one that supports svg.

Unless we drop the whole themed icons idea then we can drop imagick

[szaimen]

@SebastianKrupinski does this address #36607?

No, it still uses imagick, but it no longer requires imagick svg support, to generate icons, the icons where generated as png's anyway, it only requires imagick png support and a png logo. But it will generate themed svg icons also

If we want to generate themed icons, we have to either limit the input formats to png, and we can use another library like php-gd, or stick with imagick as its the only one that supports svg.

Unless we drop the whole themed icons idea then we can drop imagick

It seems like svg favicons are supported by all major browsers nowadays. I was wondering if it would be possible to have svgs stacked on top of each other by using masks or something for which we dont need to use imagick?

[SebastianKrupinski]

It seems like svg favicons are supported by all major browsers nowadays. I was wondering if it would be possible to have svgs stacked on top of each other by using masks or something for which we dont need to use imagick?

It's possible, but we would need to find a pure php library or someone would have to write one, then you also need to consider that the input image (logo) would have to be a svg also.