chore: config generator tool #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdewitt-newrelic
requested changes
May 2, 2025
|
One last thing. I noticed there are no unit tests. Are you planning on adding any? |
Actually I wasn't, since this tools is so simple and not a production-running artifact. But rethinking it, it's probably worth doing. |
sdewitt-newrelic
requested changes
May 14, 2025
There was a problem hiding this comment.
@asllop thanks for the changes. I think I resolved all comments but 3 if you could just have a look.
sdewitt-newrelic
requested changes
May 22, 2025
There was a problem hiding this comment.
@asllop just one unresolved comment in conftool/form/text.py where I think you meant port but used post. Would be good to change this to avoid confusion.
conftool/form/text.py
Outdated
|
|
||
| i_redis_post_min = 0 | ||
| i_redis_post_max = 65535 | ||
| t_redis_post = Text( |
There was a problem hiding this comment.
@asllop Did you see this one?
sdewitt-newrelic
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
CLI tool to build the
config.ymlrequired to run the NR Salesforce Exporter. Creating the config file could be tricky for some users, and the sample config file we provide in the repository is not enough to run the integration as is, without prior inspection and modification.Features
Future
Out of scope