Skip to content

Support for independent staging React component #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AleTorrisi
Copy link

Proposed changes

This PR uses the new independent React component available in the WP Module Staging.
PR related on WP Module Staging: newfold-labs/wp-module-staging#92

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube changed the base branch from main to develop May 28, 2025 16:26
@circlecube
Copy link
Member

@AleTorrisi can you check on this? Looks like the import isn't finding the js component. Does this PR also need to update the staging module?

@AleTorrisi
Copy link
Author

@circlecube It works fine but it's required use the PR newfold-labs/wp-module-staging#92 that has been already merged in the main branch.

@circlecube
Copy link
Member

I've made the changes in the #1094 branch/PR since it looks like we still need a staging module release to accommodate staging updates in all brand plugins.

@circlecube circlecube closed this Jun 2, 2025
@circlecube circlecube deleted the PRESS7-433/support-for-staging-react-component branch June 2, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants