Prevent _load_textdomain_just_in_time notice #1046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the recommendation to pin full length commit SHAs instead of versions or branches when using 3rd-party GitHub Actions to protect from supply chain attacks. This has been happening more often recently, with a number of popular actions having all of their tags updated with a buried vulnerability. While the new notation is more verbose, a bit ugly, and requires every update to be applied manually, we can rely on Dependabot to handle that for us to make it more manageable.
Pin full length commit SHA for 3rd party actions.
HostGator Plugin
|
||||||||||||||||||||||||||||
| Project |
HostGator Plugin
|
| Branch Review |
PRESS10-184
|
| Run status |
|
| Run duration | 29m 37s |
| Commit |
|
| Committer | Carlos Rodriguez |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
27
|
Skipped
|
0
|
Passing
|
306
|
| View all changes introduced in this branch ↗︎ | |
circlecube
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR will prevent to show the _load_textdomain_just_in_time notice and include the coming soon args via module filter.
Note: This PR will also update the coming soon module to version 1.5.0
Type of Change
Production
Development
Video
Checklist
Further comments