Pin full length commit SHA for 3rd party actions. #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the recommendation to pin full length commit SHAs instead of versions or branches when using 3rd-party GitHub Actions to protect from supply chain attacks. This has been happening more often recently, with a number of popular actions having all of their tags updated with a buried vulnerability. While the new notation is more verbose, a bit ugly, and requires every update to be applied manually, we can rely on Dependabot to handle that for us to make it more manageable.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflows to use full commit SHAs instead of version tags for third-party actions in order to enhance security against supply chain attacks.
- Replaces version tag references with pinned commit SHAs in multiple workflow files
- Updates actions including checkout, setup-php, setup-node, cache, and others across various workflows
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/wp-i18n.yml | Pinned commit SHAs for checkout, setup-php, cache, and setup-node actions. |
| .github/workflows/upload-asset-on-release.yml | Pinned commit SHAs for checkout, setup-php, setup-node, cache, and upload-release-asset. |
| .github/workflows/upload-artifact-on-push.yml | Pinned commit SHAs for checkout, setup-php, setup-node, cache, and upload-artifact. |
| .github/workflows/satis-webhook.yml | Pinned repository-dispatch action using a commit SHA. |
| .github/workflows/lint-yml.yml | Pinned commit SHAs for checkout and yamllint actions. |
| .github/workflows/lint-php.yml | Pinned commit SHAs for checkout, setup-php, get-diff, and cache actions. |
| .github/workflows/cypress-tests.yml | Pinned commit SHAs for checkout, setup-php, setup-node, cache, and upload-artifact. |
| .github/workflows/cypress-tests-beta.yml | Pinned commit SHAs for checkout, setup-php, setup-node, cache, and upload-artifact. |
| .github/workflows/cypress-matrix.yml | Pinned commit SHAs for checkout, setup-php, setup-node, cache, and upload-artifact. |
| .github/workflows/add-to-project.yml | Pinned commit SHA for the add-to-project action. |
HostGator Plugin
|
||||||||||||||||||||||||||||
| Project |
HostGator Plugin
|
| Branch Review |
gha/pin-full-length-shas
|
| Run status |
|
| Run duration | 31m 24s |
| Commit |
|
| Committer | Jonathan Desrosiers |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
29
|
Skipped
|
0
|
Passing
|
314
|
| View all changes introduced in this branch ↗︎ | |
circlecube
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This implements the recommendation to pin full length commit SHAs instead of versions or branches when using 3rd-party GitHub Actions to protect from supply chain attacks.
This has been happening more often recently, with a number of popular actions having all of their tags updated with a buried vulnerability.
While the new notation is more verbose, a bit ugly, and requires every update to be applied manually, we can rely on Dependabot to handle that for us to make it more manageable.
No actual updates to actions are happening here. The latest versions correspond with the previous notation used.
Recent examples
Examples of actions being exploited in the wild:
Production
Development
Checklist
Further comments
GitHub is looking into providing immutable releases for actions (which would allow versions to be used again), and this is currently in the Q3 2025 roadmap. But we should use full SHA values until then.
See also newfold-labs/workflows#22.