Add settings for customizing toolbar commands #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a game changer. Was looking for exactly this. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces customizable settings for toolbar commands, allowing users to specify additional commands and selectively hide default ones. Key changes include:
- Adding and exporting default toolbar commands and subgraph commands in toolbarCommands.ts.
- Refactoring Toolbar.vue to retrieve commands from viewModel settings via computed properties.
- Updating settings and documentation to support toolbar customization including a playground example with a custom command.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/renderer-vue/src/toolbar/toolbarCommands.ts | New command definitions and default command arrays are added. |
| packages/renderer-vue/src/toolbar/Toolbar.vue | Refactored to use computed toolbar commands from settings. |
| packages/renderer-vue/src/settings.ts | Updated settings interface and default values for toolbar options. |
| packages/renderer-vue/playground/App.vue | Added a custom command example showcasing toolbar customization. |
| docs/visual-editor/toolbar.md | Expanded documentation on configuring and customizing the toolbar. |
|
Sorry for the late reply and thank you for the PR! I expanded on your idea and changed it so it is also possible to change the default commands or only use a subset of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds settings that make is possible to customize the toolbar commands/buttons. Additional toolbar commands can be specified and the default toolbar commands can be hidden.
Closes #307.