Skip to content

ll: fix new clippy lints #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

ll: fix new clippy lints #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions ll/src/specifiers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,11 +354,12 @@ impl TryFrom<u8> for SocketCommand {
///
/// [`SocketMode::protocol`]: crate::SocketMode::protocol
/// [`sn_mr`]: crate::Registers::sn_mr
#[derive(Copy, Clone, Eq, PartialEq, Debug, PartialOrd, Ord, Hash)]
#[derive(Default, Copy, Clone, Eq, PartialEq, Debug, PartialOrd, Ord, Hash)]
#[cfg_attr(feature = "defmt", derive(defmt::Format))]
#[repr(u8)]
pub enum Protocol {
/// Closed.
#[default]
Closed = 0b0000,
/// TCP.
Tcp = 0b0001,
Expand Down Expand Up @@ -403,11 +404,6 @@ impl From<Protocol> for u8 {
val as u8
}
}
impl Default for Protocol {
fn default() -> Self {
Self::Closed
}
}
impl TryFrom<u8> for Protocol {
type Error = u8;
fn try_from(val: u8) -> Result<Self, u8> {
Expand All @@ -421,7 +417,7 @@ impl TryFrom<u8> for Protocol {
///
/// [`PhyCfg::opmdc`]: crate::PhyCfg::opmdc
/// [`phycfgr`]: crate::Registers::phycfgr
#[derive(Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Debug, Hash)]
#[derive(Default, Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Debug, Hash)]
#[cfg_attr(feature = "defmt", derive(defmt::Format))]
#[repr(u8)]
pub enum OperationMode {
Expand All @@ -438,6 +434,7 @@ pub enum OperationMode {
/// Power down mode.
PowerDown = 0b110,
/// All capable. Auto-negotiation enabled.
#[default]
Auto = 0b111,
}
impl OperationMode {
Expand Down Expand Up @@ -491,11 +488,6 @@ impl From<OperationMode> for u8 {
val as u8
}
}
impl Default for OperationMode {
fn default() -> Self {
Self::Auto
}
}

/// PHY link status.
///
Expand Down