Update syn.mod #3439
Open
Update syn.mod #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please ignore my prevous pull request re: this file. This is what the comment block should say.
|
✔️ 6b69324 -> artifacts URL |
|
|
✔️ 6b69324 -> Azure artifacts URL |
nrnhines
reviewed
May 23, 2025
| @@ -3,7 +3,7 @@ a synaptic current with alpha function conductance defined by | |||
| i = g * (v - e) i(nanoamps), g(microsiemens); | |||
| where | |||
| g = 0 for t < onset and | |||
| g = gmax * (t - onset)/tau * exp(-(t - onset - tau)/tau) | |||
There was a problem hiding this comment.
The - tau looks strange but is correct given that when t - onset == tau the value is gmax since exp(0) == 1.0
| @@ -3,7 +3,7 @@ a synaptic current with alpha function conductance defined by | |||
| i = g * (v - e) i(nanoamps), g(microsiemens); | |||
| where | |||
| g = 0 for t < onset and | |||
| g = gmax * (t - onset)/tau * exp(-(t - onset - tau)/tau) | |||
| g = gmax * (t - onset)/tau * exp(-(t - onset)/tau) | |||
| for t > onset | |||
| this has the property that the maximum value is gmax and occurs at | |||
| t = delay + tau. | |||
There was a problem hiding this comment.
the delay should be called onset
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3439 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 682 682
Lines 116525 116525
=======================================
Hits 79684 79684
Misses 36841 36841 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore my prevous pull request re: this file. This is what the comment block should say.