-
Notifications
You must be signed in to change notification settings - Fork 125
cvode no_cap uses direct backing store instead of Node* #3314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cellcontig+scatter-ptr
|
✔️ 2123efe -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3314 +/- ##
==========================================
+ Coverage 68.38% 68.42% +0.04%
==========================================
Files 682 682
Lines 116556 116565 +9
==========================================
+ Hits 79705 79760 +55
+ Misses 36851 36805 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✔️ 865a22c -> artifacts URL |
✔️ 2e126df -> Azure artifacts URL |
✔️ 2e126df -> artifacts URL |
✔️ 190c009 -> artifacts URL |
✔️ 190c009 -> Azure artifacts URL |
✔️ 7caee3c -> artifacts URL |
✔️ 7caee3c -> Azure artifacts URL |
✔️ 12aa723 -> artifacts URL |
✔️ 12aa723 -> Azure artifacts URL |
|
✔️ 051f346 -> Azure artifacts URL |
✔️ 74141e7 -> artifacts URL |
✔️ 051f346 -> artifacts URL |
This is the latest in a series of PR's and branches that are meant to improve cvode performance to the level of release/8.2
The series is
hines/cvlocal-bug #3299
hines/cell-contiguous #3300
hines/cellcontig+scatter-ptr https://github.com/neuronsimulator/nrn/tree/hines/cellcontig%2Bscatter-ptr
hines/cellcontig-scatter-treemat https://github.com/neuronsimulator/nrn/tree/hines/cellcontig-scatter-treemat
this PR
This PR generally approaches or exceeds the performance of 8.2 (at least for x86_64) with respect to cvode. Ringtest performance is (data copied from #3283 (comment))
There continues to be an issue with Apple M1