Skip to content

cvode no_cap uses direct backing store instead of Node* #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jun 4, 2025

Conversation

nrnhines
Copy link
Member

@nrnhines nrnhines commented Jan 21, 2025

This is the latest in a series of PR's and branches that are meant to improve cvode performance to the level of release/8.2
The series is
hines/cvlocal-bug #3299
hines/cell-contiguous #3300
hines/cellcontig+scatter-ptr https://github.com/neuronsimulator/nrn/tree/hines/cellcontig%2Bscatter-ptr
hines/cellcontig-scatter-treemat https://github.com/neuronsimulator/nrn/tree/hines/cellcontig-scatter-treemat
this PR

This PR generally approaches or exceeds the performance of 8.2 (at least for x86_64) with respect to cvode. Ringtest performance is (data copied from #3283 (comment))

nrniv -python ringtest.py -npt 1 -compart 1 3 -nring 32 -rparm -nt 1

x86_64 intel icx
version  fixed  global  local
8.2      1.86   30.5    1.35
master   1.53   56.0    6.67
contig   1.59   60.8    2.76
scatter  1.71   48.4    2.32
treemat  1.61   35.9    2.01
nocap    1.6    25.1    1.78

x86_64 gcc 13.3.0
version  fixed  global  local
8.2          2.92   51.9    2.47
master   2.38   63.4    6.19
contig    2.09   63.6    3.10
scatter   1.98   49.8    2.54
treemat  2.01   38.7    2.25
nocap     2.01   28.4    2.01

There continues to be an issue with Apple M1

Apple M1
version  fixed  global  local
8.2         1.87    23.67   1.32
master  4.1      60.1      5.3
contig    5.0      70.5      4.1
scatter   4.9      64.6      3.8
treemat 4.1      47.5      2.9
nocap    4.9      58.3      3.47
coreneuron 2.0

Copy link

Copy link

✔️ 2123efe -> Azure artifacts URL

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.42%. Comparing base (0b9477a) to head (051f346).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
+ Coverage   68.38%   68.42%   +0.04%     
==========================================
  Files         682      682              
  Lines      116556   116565       +9     
==========================================
+ Hits        79705    79760      +55     
+ Misses      36851    36805      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

✔️ 865a22c -> artifacts URL

Copy link

✔️ 2e126df -> Azure artifacts URL

Copy link
Contributor

✔️ 2e126df -> artifacts URL

Copy link
Contributor

github-actions bot commented Jun 2, 2025

✔️ 190c009 -> artifacts URL

Copy link

✔️ 190c009 -> Azure artifacts URL

Copy link
Contributor

github-actions bot commented Jun 2, 2025

✔️ 7caee3c -> artifacts URL

Copy link

✔️ 7caee3c -> Azure artifacts URL

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✔️ 12aa723 -> artifacts URL

Copy link

✔️ 12aa723 -> Azure artifacts URL

Copy link

sonarqubecloud bot commented Jun 3, 2025

Copy link

✔️ 051f346 -> Azure artifacts URL

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✔️ 74141e7 -> artifacts URL

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✔️ 051f346 -> artifacts URL

@nrnhines nrnhines merged commit b37e37c into master Jun 4, 2025
43 checks passed
@nrnhines nrnhines deleted the hines/cellcontig-treemat2 branch June 4, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants