fix string -> int #336
Open
fix string -> int #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for rerf ready! Built with commit aa4f5a1 |
|
why did run time go up? |
|
The labels were strings. Not sure if it was running properly the first time. |
|
pybind11 may have been doing the conversion for us, but agree, this is
better. but even better than this would be validation in the class itself
to ensure that the class labels are integers, or to just convert them there.
…On Wed, Oct 2, 2019 at 3:03 PM Jesse Leigh Patsolic < ***@***.***> wrote:
The labels were strings. Not sure if it was running properly the first
time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#336?email_source=notifications&email_token=AAE7NZ6VIAIN254QLYHEYXDQMTWAXA5CNFSM4I4ZJ4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAF2P4A#issuecomment-537634800>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE7NZ3VOKMWNFBLRJXZYLDQMTWAXANCNFSM4I4ZJ4GQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.