Skip to content

Conversation

parthgvora
Copy link
Contributor

Reference issue

Type of change

Draft of SPORF. Contains cythonization, parameters equivalent to RerF, and various bug fixes from previous python-only iteration. Still needs work!

What does this implement/fix?

Additional information

PSSF23
PSSF23 previously approved these changes Mar 21, 2021
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest linking to some DoD and show what your codes improved. But as this is a development branch, merging would not require the full procedure.

@PSSF23 PSSF23 added the draft In progress PR label Mar 21, 2021
from .morf_tree import Conv2DObliqueTreeClassifier


class Conv2DObliqueForestClassifier(ForestClassifier):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short and sweet.

@PSSF23 PSSF23 deleted the branch neurodata:sporf November 4, 2021 15:29
@PSSF23 PSSF23 closed this Nov 4, 2021
@PSSF23 PSSF23 reopened this Nov 5, 2021
@PSSF23 PSSF23 dismissed their stale review November 5, 2021 19:32

outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

draft In progress PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants