Skip to content

Add torch.float64 as a viable dtype for scales #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Add torch.float64 as a viable dtype for scales #379

merged 1 commit into from
Jul 9, 2025

Conversation

eldarkurtic
Copy link
Contributor

No description provided.

brian-dellabetta
brian-dellabetta reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense if users want float64 scales, suggestion to make this more generic/futureproof

@eldarkurtic
Copy link
Contributor Author

@brian-dellabetta i am that user with the need for scales in fp64 😅

@kylesayrs kylesayrs merged commit e4eb3fb into main Jul 9, 2025
1 check passed
@kylesayrs kylesayrs deleted the eldarkurtic-patch-2 branch July 9, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsikka dsikka dsikka left review comments

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@kylesayrs kylesayrs kylesayrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldarkurtic @brian-dellabetta @kylesayrs @dsikka