Skip to content

[Transform] apply_transform_config #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 88 commits into from
Jul 9, 2025
Merged

[Transform] apply_transform_config #348

merged 88 commits into from
Jul 9, 2025

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Jun 10, 2025

Purpose

  • Implement transform apply method
  • Consolidate test fixtures

Prerequisites

Changes

  • Implement apply_transform_config
  • Use tests/test_transform/conftest.py to define a valid model and transform config for testing

Testing

  • Transform tests pass

kylesayrs added 30 commits May 30, 2025 13:40
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Base automatically changed from kylesayrs/transform_construct_cache_device to main July 7, 2025 16:48
@kylesayrs kylesayrs dismissed brian-dellabetta’s stale review July 7, 2025 16:48

The base branch was changed.

shanjiaz
shanjiaz previously approved these changes Jul 8, 2025
Copy link
Contributor

@shanjiaz shanjiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward. Thanks for adding tests!

@kylesayrs
Copy link
Contributor Author

kylesayrs commented Jul 8, 2025

Prerequed on vllm-project/llm-compressor#1628

EDIT: now merged

@kylesayrs kylesayrs marked this pull request as draft July 8, 2025 17:20
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@kylesayrs kylesayrs dismissed stale reviews from shanjiaz and brian-dellabetta via fd77ecc July 8, 2025 19:42
@kylesayrs kylesayrs marked this pull request as ready for review July 9, 2025 17:57
Copy link
Contributor

@shanjiaz shanjiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dsikka dsikka merged commit b163bd9 into main Jul 9, 2025
1 check passed
@dsikka dsikka deleted the kylesayrs/transform_apply branch July 9, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants