[Bugfix] Safeguard against submodule parameter deletion in decompress_model #347
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-dellabetta
previously approved these changes
Jun 10, 2025
| @@ -479,7 +479,7 @@ def decompress_model(self, model: Module): | |||
| # remove any existing parameters | |||
| exec_device = get_execution_device(module) | |||
| offload_device = get_offloaded_device(module) | |||
| for name, _ in list(module.named_parameters()): | |||
| for name, _ in list(module.named_parameters(recurse=False)): | |||
There was a problem hiding this comment.
it seems like we want to recurse in this case, to get all nested named parameters, but i must be missing something
There was a problem hiding this comment.
Kind of technically. A lot of this code already makes assumptions that the module being compressed is already a child module, so you're right that this probably doesn't guard against anything that wouldn't error somewhere else in this function
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
kylesayrs
force-pushed
the
kylesayrs/model_decompress_safeguard
branch
from
2c7e300 to
342e3ca
Compare
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
iter_named_leaf_modulesanditer_named_quantizable_modules#381, this was skipped byiter_leaf_modules