Skip to content

[Bugfix] Fix find_name_or_class_matches return type #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Jun 9, 2025

Background

  • This check was initially added by initial fixes for compatibility with HFQuantizer #79 with no reasoning given. Given that this function should error if a non-iterable is passed anyways (sorted call should error first if not iterable), I believe they are safe to make without breaking anything. If errors to occur, they should be fixed upstream, not in this function.

Changes

  • Remove unnecessary type check which would have resulted in the function returning None, which breaks its function contract

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants