-
Notifications
You must be signed in to change notification settings - Fork 15
[Hotfix] Implement quantization compressor methods on dense compressor #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just delete the dense compressor?
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@rahul-tuli We can talk more about this somewhere else. I'd rather keep the/a dense compressor and get rid of the nullable property of compressors. This would make a lot of code much cleaner. if compressor is not None:
compressor.compress(model)
if compressor is not None:
compressor.decompress(model) is a lot more annoying to check every time you want to use a compressor programmatically, rather than a simply narrow type compressor.compress(model)
compressor.decompress(model) |
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Sounds good @kylesayrs, could you create a ticket/issue so we remember to revisit this? Approving the PR! |
src/compressed_tensors/compressors/model_compressors/model_compressor.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Background
Purpose
Changes
decompress_module_from_state_dict
on DenseCompressor