fix: polish and improve deploy command output #7250
+61
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed recently, oops.
Move deploy URL(s) to its own primary section in a callout box - It's the primary call-to-action, so it should be the primary focus - It's a little more celebratory/satisfying - I moved the "draft" vs. "production" mention to this box - Use OSC 8 "terminal links" when supported - Use Netlify cyan and distinctive diamond
serhalp
commented
May 1, 2025
| ), | ||
| ) | ||
| log('If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag:') | ||
| log(chalk.cyanBright.bold(`netlify deploy${runBuildCommand ? '' : '--no-build'} --prod`)) |
There was a problem hiding this comment.
this is unrelated, just a little thing we missed in #7195
serhalp
commented
May 1, 2025
| @@ -893,11 +903,8 @@ export const deploy = async (options: DeployOptionValues, command: BaseCommand) | |||
| deployToProduction, | |||
| }) | |||
| } | |||
| const isIntegrationDeploy = command.name() === 'integration:deploy' | |||
There was a problem hiding this comment.
dead code, integration:deploy was removed in December
serhalp
commented
May 1, 2025
| @@ -16,7 +16,7 @@ export const sitesList = async (options: OptionValues, command: BaseCommand) => | |||
|
|
|||
| const sites = await listSites({ api, options: { filter: 'all' } }) | |||
| if (spinner) { | |||
| stopSpinner({ spinner }) | |||
| spinner.success() | |||
There was a problem hiding this comment.
oops, sorry, another unrelated change — when I was fixing the deploy spinner end state I searched for others with the same pattern and found this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As in #7249, this makes misc. improvements to the output of
ntl deploy, in order to improve the signal-to-noise ratio, improve clarity, and make it a little more pleasant to look at:Before
After
(the first few seconds are the same, but the full log is relevant to understand redundancy and consistency)
and for completeness here's a production deploy:
Notes
Reviewer, I suggest reviewing by commit!