Skip to content

fix: upgrade @types/node to v18 #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

fix: upgrade @types/node to v18 #6400

merged 2 commits into from
May 28, 2025

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented May 27, 2025

Summary

  • Update node/types to v18
  • Convert buffers into blobs before calling blobStore.set (fix a type issue)

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork requested a review from a team as a code owner May 27, 2025 15:52
@mrstork mrstork changed the title fix: upgrade @node/types to v18.14.* fix: upgrade @node/types to v18.14.0 May 27, 2025
serhalp
serhalp previously approved these changes May 27, 2025
@serhalp serhalp changed the title fix: upgrade @node/types to v18.14.0 fix: upgrade @types/node to v18.14.0 May 27, 2025
@mrstork mrstork force-pushed the upgrade-node-types branch from 355d006 to c000e9f Compare May 27, 2025 17:50
@mrstork mrstork changed the title fix: upgrade @types/node to v18.14.0 fix: upgrade @types/node to ^v18.14.0 May 27, 2025
@mrstork mrstork changed the title fix: upgrade @types/node to ^v18.14.0 fix: upgrade @types/node to v18 May 27, 2025
@mrstork mrstork force-pushed the upgrade-node-types branch from a6e4c8a to 78161bb Compare May 28, 2025 17:19
@mrstork mrstork enabled auto-merge (squash) May 28, 2025 17:24
@mrstork mrstork merged commit efcc052 into main May 28, 2025
33 checks passed
@mrstork mrstork deleted the upgrade-node-types branch May 28, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants