Skip to content

chore!: upgrade to tailwindcss 4 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore!: upgrade to tailwindcss 4 #86

wants to merge 12 commits into from

Conversation

andre8244
Copy link
Collaborator

@andre8244 andre8244 commented May 28, 2025

  • Upgrade TailwindCSS to major version 4
  • Upgrade to Storybook 9
  • Add optionsPanelStyle to NeListbox component

@andre8244 andre8244 self-assigned this May 28, 2025
@andre8244 andre8244 changed the title chore!: upgrade tailwindcss to v4 (wip) chore!: upgrade to tailwindcss 4 May 30, 2025
@andre8244 andre8244 marked this pull request as ready for review June 5, 2025 08:14
@andre8244 andre8244 requested review from Copilot and Tbaile June 5, 2025 08:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Upgrade TailwindCSS to v4, bump Storybook to v9, and add a new styling prop to NeListbox.

  • Update Tailwind utility syntax (arbitrary values, slash opacity, focus:outline-hidden)
  • Upgrade Storybook dependencies and adjust config for v9
  • Introduce optionsPanelStyle prop to NeListbox for greater styling flexibility

Reviewed Changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/NeModal.vue Updated z-index and opacity utilities; reordered classes for Tailwind 4 syntax
src/components/NeListbox.vue Added optionsPanelStyle prop; applied custom class binding and reordered utilities
src/components/NeLink.vue Adjusted theme color tokens for standard/inverted links
src/components/NeInlineNotification.vue Replaced deprecated focus:outline-none with focus:outline-hidden and reordered classes
src/components/NeFormItemLabel.vue Reordered text and layout utilities
src/components/NeFileInput.vue Tweaked margin utility—with a potential typo—and reordered classes
src/components/NeEmptyState.vue Reordered background and responsive utilities
src/components/NeDropdownFilter.vue Updated focus utilities, spacing and width classes; replaced arbitrary widths
src/components/NeDropdown.vue Tweaked menu background/ring utilities and default item classes
src/components/NeCombobox.vue Updated focus utilities, spacing, and default option classes
src/components/NeCheckbox.vue Reordered focus utilities and border classes
src/components/NeCard.vue Reordered text utilities and layout classes
src/components/NeButton.vue Updated focus utilities and reordered class list
postcss.config.js Deleted in favor of Vite-native Tailwind setup?
package.json Bumped deps (Tailwind v4, Storybook 9), added overrides for Storybook
README.md Updated installation guide for Tailwind 4 layering and plugin inclusion
Containerfile Removed copying of PostCSS and Tailwind config files
.storybook/storybook.css Added reference to project’s main CSS file
.storybook/preview.ts Switched imports to new packages; adjusted story wrapper template
.storybook/main.ts Updated addons list for Storybook 9
Comments suppressed due to low confidence (6)

postcss.config.js:1

  • The entire postcss.config.js was removed. Ensure that Tailwind’s nesting plugin and Autoprefixer are configured elsewhere (e.g., in vite.config.js), or the build may break.
export default {

Containerfile:11

  • You've stopped copying postcss.config.js and tailwind.config.ts into the container. Confirm that your container build still has the required Tailwind and PostCSS configs.
COPY postcss.config.js .

src/components/NeListbox.vue:43

  • [nitpick] The new optionsPanelStyle prop is not documented in the component’s JSDoc or Storybook stories. Consider adding usage examples and prop descriptions.
optionsPanelStyle?: string

src/components/NeFileInput.vue:101

  • The utility class -mb-2! appears misplaced: Tailwind uses !-mb-2 to mark important styles. Please correct this to !-mb-2 or remove the trailing ! if unintended.
<p class="-mb-2! font-medium">

.storybook/preview.ts:3

  • The import path storybook/test looks incorrect—Storybook’s test functions are provided by @storybook/test. Please update the import to from '@storybook/test'.
import { fn } from 'storybook/test'

package.json:94

  • The overrides field mapping storybook to $storybook is unusual. Confirm this override is needed, as it may cause unexpected dependency resolution.
"storybook": "$storybook"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants