[NAE-2058] Role refactor #282

Retoocs · 2025-05-29T08:50:00Z

Description

Components and components-core were updated according to backend changes. No new feature introduced.

Implements NAE-2058

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Just manually. Tests are going to be updated in another task.

Test Configuration

Name	Tested on
OS	Ubuntu 24.04.1 LTS
Runtime	Node 23.6.1
Dependency Manager	NPM 11.0.0
Framework version	Angular 19.2.2
Run parameters
Other configuration

Checklist:

- corrected according to PR

- removed line

- added line

# Conflicts: # projects/netgrif-components-core/src/lib/task-content/services/field-converter.service.ts

[NAE-1911] Autosave on text area in cooperation with button

[NAE-1497] Frontend actions

- updated changelog - updated version

- refactor loading items on left and right side - implement backend item sorting

- rework of caseref to multichoice

- apply backend sorting of menu items - change sorting icon

- corrected set of field.changed

- reverted set of field.changed - after discussion, found solution for checking field contextually

- modified algorithm of resolving taskref behaviour

- allow leftMenu to display items without children and custom items - fix console error

- rework of caseref to multichoice - rework of caseref to enumeration - rework of single task view without virtual scroll

- fix height of single task dialog

[NAE-1915] TaskRef behaviour handling for multiple level

- fix test

Nae 1904 Case ref as multichoice and enumeration

# Conflicts: # projects/netgrif-components/src/lib/navigation/group-navigation-component-resolver/default-components/default-case-ref-list-view/default-case-ref-list-view.component.ts

- fixes of user field

- fixes of multichoice autocomplete

- fix tests

# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components-core/src/lib/data-fields/file-field/abstract-file-field.component.ts # projects/netgrif-components/nae-theme.scss # projects/netgrif-components/package.json # projects/netgrif-components/src/lib/data-fields/button-field/button-default-field/button-default-field.component.scss # projects/netgrif-components/src/lib/data-fields/data-field.theme.scss # projects/netgrif-components/src/lib/data-fields/user-list-field/user-list-default-field/user-list-default-field.component.html

- implement grid/flex layout - remove dataGroups - update engine petriNets on new layouts

- cleanup

- update to 18

- update to angular 19 and fix problems in build

- rename user to identity - fix login to work with backend

- remove unused interfaces: IdentityResourceSmall, NetRole, PetriNetReferenceWithPermissions, RolesAndPermissions - rename attributes: email to username, processRoles to roles - remove roles and permissions logic from process service - update permissions interface to add viewDisabled property - replace UserComparatorService with ActorComparatorService - update user invitation and signup functionality - update case-header to use authorId instead of author object - remove obsolete code related to roles in UI components - add todo comments for role management related code

- refactor ProcessRole interface and move to roles folder - create Role base interface - add CaseRole and ApplicationRole interfaces - implement RbacResourceService for role management - update nae.json with RBAC configuration - add unit tests for RbacResourceService

- rename processRole.ts, caseRole.ts, and applicationRole.ts to use kebab-case - rename CaseRole to CaseProcessRole - update imports to reflect new file names - adjust references and tests to renamed classes and files

- remove ActorResourceService and its test - add hasRole logic to ActorService

- remove visualId header - implement ActorService.isAdmin - reimplement permission handling in permission.service

- fix ActorService attributes values after identity change - introduce PermissionsWrapper as result of backend changes

- fix workflow component - implement properties initialization for process - fix UriNodeResource id attribute

- remove impersonation

- remove role assign component

- implement IdentityResourceService.getPublicLoggedIdentity

- fixes

coderabbitai · 2025-05-29T08:50:07Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Kovy95 · 2025-05-30T07:18:08Z

.github/workflows/pr-build.yml

@@ -8,7 +8,7 @@ jobs:
        runs-on: ubuntu-latest
        strategy:
            matrix:
-                node-version: [ 12, 14, 16, 18 ]
+                node-version: [ 14, 16, 18 ]


should we add node 20 ?

renczesstefan and others added 30 commits July 25, 2023 11:58

[NAE-1497] Frontend Actions

bbfc953

- corrected according to PR

Merge branch 'master' into release/6.3.2

049ad2f

Release/6.3.2-rc.1

465207d

Merge branch 'release/6.3.2' into NAE-1911

68aa13b

- revert commit c3ab24f

9b377ec

[NAE-1911] Autosave on text area in cooperation with button

c2f49b1

- removed line

[NAE-1911] Autosave on text area in cooperation with button

074d34d

- removed line

[NAE-1911] Autosave on text area in cooperation with button

c739760

- removed line

[NAE-1911] Autosave on text area in cooperation with button

44e468e

- added line

Merge branch 'release/6.3.2' into NAE-1911

69ab019

# Conflicts: # projects/netgrif-components-core/src/lib/task-content/services/field-converter.service.ts

Merge pull request #212 from netgrif/NAE-1911

11d14a8

[NAE-1911] Autosave on text area in cooperation with button

Merge pull request #209 from netgrif/NAE-1497

2c6960f

[NAE-1497] Frontend actions

Release/6.3.2-rc.1

4a32035

Release/6.4.0-beta.5

1bce589

- updated changelog - updated version

- corrected import

3ec113d

[NAE-1908] NAE-1906 Improvements

72a600b

- refactor loading items on left and right side - implement backend item sorting

[NAE-1904] CaseRef list process component

b5689e2

- rework of caseref to multichoice

Merge remote-tracking branch 'origin/NAE-1906' into NAE-1904

58af25e

[NAE-1908] NAE-1906 Improvements

877f205

- apply backend sorting of menu items - change sorting icon

[NAE-1914] revertToPreviousValue - change is always false

87a08cb

- corrected set of field.changed

[NAE-1914] revertToPreviousValue - change is always false

bd2eb0c

- reverted set of field.changed - after discussion, found solution for checking field contextually

[NAE-1915] TaskRef behaviour handling for multiple level

280eae1

- modified algorithm of resolving taskref behaviour

[NAE-1908] NAE-1906 Improvements

bcc4276

- allow leftMenu to display items without children and custom items - fix console error

[NAE-1904] CaseRef list process component

46c81ae

- rework of caseref to multichoice - rework of caseref to enumeration - rework of single task view without virtual scroll

[NAE-1904] CaseRef list process component

4ac4bb4

- fix height of single task dialog

Merge pull request #214 from netgrif/NAE-1915

a211265

[NAE-1915] TaskRef behaviour handling for multiple level

Release/6.4.0-beta.6

1c546fb

[NAE-1908] NAE-1906 Improvements

4b679f1

- fix test

Merge pull request #215 from netgrif/NAE-1904

3105ac0

Nae 1904 Case ref as multichoice and enumeration

Merge remote-tracking branch 'origin/NAE-1906' into NAE-1908

6aff4c8

# Conflicts: # projects/netgrif-components/src/lib/navigation/group-navigation-component-resolver/default-components/default-case-ref-list-view/default-case-ref-list-view.component.ts

Kovy95 and others added 21 commits June 14, 2024 16:14

[NAE-1940] Update to new Angular

fff72c5

- fixes of user field

[NAE-1940] Update to new Angular

14a9980

- fixes of multichoice autocomplete

[NAE-1940] Update to new Angular

4b0e673

- fix tests

[NAE-1964] Grid layout

4ad7ea7

- implement grid/flex layout - remove dataGroups - update engine petriNets on new layouts

[NAE-1964] Grid layout

6caa00f

- cleanup

[NAE-1964] Grid layout

f3c56f9

- cleanup

[NAE-2062] - Angular 19

c5bfae7

- update to 18

[NAE-2062] - Angular 19

7b346cc

- update to angular 19 and fix problems in build

[NAE-2058] Role refactor

0a5354a

- rename user to identity - fix login to work with backend

[NAE-2058] Role refactor

3e9bf06

- rename processRole.ts, caseRole.ts, and applicationRole.ts to use kebab-case - rename CaseRole to CaseProcessRole - update imports to reflect new file names - adjust references and tests to renamed classes and files

[NAE-2058] Role refactor

f4a57ed

- remove ActorResourceService and its test - add hasRole logic to ActorService

[NAE-2058] Role refactor

520b10a

- remove visualId header - implement ActorService.isAdmin - reimplement permission handling in permission.service

[NAE-2058] Role refactor

f61fbce

- fix ActorService attributes values after identity change - introduce PermissionsWrapper as result of backend changes

[NAE-2058] Role refactor

4431abf

- fix workflow component - implement properties initialization for process - fix UriNodeResource id attribute

[NAE-2058] Role refactor

7a07eb2

- remove impersonation

[NAE-2058] Role refactor

e58c5bd

- remove role assign component

[NAE-2058] Role refactor

ac068ff

- implement IdentityResourceService.getPublicLoggedIdentity

[NAE-2058] Role refactor

33ab671

- fixes

Retoocs requested review from camperko, Kovy95, SamuelPalaj, MartinSiran and mazarijuraj May 29, 2025 08:50

Retoocs self-assigned this May 29, 2025

Retoocs added the improvement New feature or request label May 29, 2025

Kovy95 reviewed May 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[NAE-2058] Role refactor #282

[NAE-2058] Role refactor #282

Uh oh!

Retoocs commented May 29, 2025 •

edited by jira bot

Loading

Uh oh!

coderabbitai bot commented May 29, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Kovy95 May 30, 2025

Uh oh!

Uh oh!

[NAE-2058] Role refactor #282

Are you sure you want to change the base?

[NAE-2058] Role refactor #282

Uh oh!

Conversation

Retoocs commented May 29, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Third party dependencies

Blocking Pull requests

How Has Been This Tested?

Test Configuration

Checklist:

Uh oh!

coderabbitai bot commented May 29, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Kovy95 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Retoocs commented May 29, 2025 •

edited by jira bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)