Skip to content

Adhere to DCM 1.28.1 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/netglade_analysis/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
## 17.0.0
- Adhere to DCM 1.28.1
- Add avoid-recursive-tostring
- Add avoid-enum-values-by-index
- Add avoid-constant-assert-conditions
- Add avoid-nested-assignments
- Add avoid-unnecessary-compare-to
- Add prefer-digit-separators
- Add avoid-unnecessary-digit-separators
- Add avoid-inconsistent-digit-separators
- Add pass-existing-future-to-future-builder
- Add pass-existing-stream-to-stream-builder
- Add prefer-compute-over-isolate-run

## 16.1.0
- Setup DCM Metrics

Expand Down
11 changes: 11 additions & 0 deletions packages/netglade_analysis/lib/dcm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ dart_code_metrics:
- avoid-complex-arithmetic-expressions
- avoid-complex-loop-conditions
- avoid-conditions-with-boolean-literals
- avoid-constant-assert-conditions
# - avoid-continue # we prefer condition guards
- avoid-contradictory-expressions
- avoid-declaring-call-method
Expand All @@ -48,6 +49,7 @@ dart_code_metrics:
include-methods:
- blocTest
- blocPresentationTest
- avoid-enum-values-by-index
- avoid-equal-expressions
- avoid-excessive-expressions
- avoid-explicit-pattern-field-name
Expand All @@ -68,6 +70,7 @@ dart_code_metrics:
- test/**
- avoid-implicitly-nullable-extension-types
- avoid-importing-entrypoint-exports
- avoid-inconsistent-digit-separators
- avoid-incorrect-uri
- avoid-inferrable-type-arguments:
ignored-invocations:
Expand Down Expand Up @@ -96,6 +99,7 @@ dart_code_metrics:
# - avoid-mutating-parameters # we use ValueNotifier etc.
# - avoid-negated-conditions # sometimes it might be better
- avoid-negations-in-equality-checks
- avoid-nested-assignments
- avoid-nested-conditional-expressions:
acceptable-level: 2
- avoid-nested-extension-types
Expand Down Expand Up @@ -128,6 +132,7 @@ dart_code_metrics:
- avoid-passing-self-as-argument
- avoid-positional-record-field-access
- avoid-recursive-calls
- avoid-recursive-tostring
- avoid-redundant-async
- avoid-redundant-else
- avoid-redundant-positional-field-name
Expand Down Expand Up @@ -161,9 +166,11 @@ dart_code_metrics:
- avoid-unnecessary-block
- avoid-unnecessary-call
- avoid-unnecessary-collections
- avoid-unnecessary-compare-to
- avoid-unnecessary-conditionals
- avoid-unnecessary-constructor
- avoid-unnecessary-continue
- avoid-unnecessary-digit-separators
- avoid-unnecessary-enum-arguments
- avoid-unnecessary-enum-prefix
- avoid-unnecessary-extends
Expand Down Expand Up @@ -336,6 +343,7 @@ dart_code_metrics:
# - prefer-correct-throws # for now hard to maintain
- prefer-correct-type-name
- prefer-declaring-const-constructor
- prefer-digit-separators
- prefer-early-return
- prefer-enums-by-name
- prefer-expect-later
Expand Down Expand Up @@ -437,9 +445,12 @@ dart_code_metrics:
- check-for-equals-in-render-object-setters
- consistent-update-render-object
- dispose-fields
- pass-existing-future-to-future-builder
- pass-existing-stream-to-stream-builder
- prefer-action-button-tooltip
- prefer-align-over-container
- prefer-center-over-align
- prefer-compute-over-isolate-run
- prefer-const-border-radius
- prefer-container:
min-sequence: 2
Expand Down
2 changes: 1 addition & 1 deletion packages/netglade_analysis/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: netglade_analysis
version: 16.1.0
version: 17.0.0
description: Lint rules for Dart and Flutter used internally at netglade.
repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_analysis
issue_tracker: https://github.com/netglade/flutter_core/issues
Expand Down
Loading