Merge pull request #13 from netglade/fix-issues

Fix issues

Author: tenhobi

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 4.1.0
+- Temporarily remove (its WIP and not recognized):
+  - no_wildcard_variable_uses
+  - no_self_assignments
+- Remove no-equal-arguments
+
 ## 4.0.0
 - Adhere to DCM 1.8.0:
   - Add prefer-custom-finder-over-find

lib/dcm.yaml

@@ -153,18 +153,18 @@ dart_code_metrics:
     - no-boolean-literal-compare:
         allow-false: true # allows `variable == false` instead of just `!variable`
     - no-empty-block
-    - no-equal-arguments:
-        ignored-parameters:
-          - height
-          - width
-          - top
-          - right
-          - bottom
-          - left
-          - topLeft
-          - topRight
-          - bottomLeft
-          - bottomRight
+    # - no-equal-arguments: # TODO: hard to set up so it makes sense
+    #     ignored-parameters:
+    #       - height
+    #       - width
+    #       - top
+    #       - right
+    #       - bottom
+    #       - left
+    #       - topLeft
+    #       - topRight
+    #       - bottomLeft
+    #       - bottomRight
     - no-equal-conditions
     - no-equal-nested-conditions
     - no-equal-switch-case

lib/lints.yaml

@@ -45,8 +45,8 @@ linter:
     - no_adjacent_strings_in_list
     - no_duplicate_case_values
     - no_logic_in_create_state
-    - no_self_assignments
-    - no_wildcard_variable_uses
+    # - no_self_assignments WIP
+    # - no_wildcard_variable_uses WIP
     # - prefer_relative_imports
     - prefer_void_to_null
     - test_types_in_equals

pubspec.yaml

@@ -1,5 +1,5 @@
 name: netglade_analysis
-version: 4.0.0
+version: 4.1.0
 description: Lint rules for Dart and Flutter used internally at netglade.
 repository: https://github.com/netglade/netglade_analysis
 issue_tracker: https://github.com/netglade/netglade_analysis/issues