Merge pull request #12 from netglade/release/4.0.0

Update to 4.0.0

Author: tenhobi

CHANGELOG.md

@@ -1,3 +1,23 @@
+## 4.0.0
+- Adhere to DCM 1.8.0:
+  - Add prefer-custom-finder-over-find
+  - Add prefer-symbol-over-key
+  - Add avoid-map-keys-contains
+  - Add avoid-async-call-in-sync-function
+  - Add avoid-duplicate-mixins
+  - Add avoid-nullable-interpolation
+  - Add avoid-unused-instances
+  - Add enum-constants-ordering
+  - Add prefer-named-boolean-parameters
+  - Add prefer-correct-for-loop-increment
+  - Add prefer-public-exception-classes
+  - Add avoid-unnecessary-reassignment
+  - Add avoid-recursive-widget-calls
+  - Add prefer-text-rich
+- Adhere to Dart lints 3.1.0:
+  - Add no_self_assignments
+  - Add no_wildcard_variable_uses
+
 ## 3.0.0
 - Adhere to DCM 1.7.0:
   - Add avoid-accessing-other-classes-private-members

README.md

@@ -27,7 +27,7 @@ To use the lints, add as a dev dependency in your `pubspec.yaml`:
 
 ```yaml
 dev_dependencies:
-  netglade_analysis: ^2.0.0
+  netglade_analysis: ^4.0.0
 ```
 
 Then, add an include in `analysis_options.yaml`:

lib/dcm.yaml

@@ -1,4 +1,4 @@
-# version 1.7.0 - https://dcm.dev/changelog/
+# version 1.8.0 - https://dcm.dev/changelog/
 dart_code_metrics:
   pubspec-rules:
     ### Pubspec
@@ -15,6 +15,7 @@ dart_code_metrics:
     ### Common
     # - arguments-ordering # way too pedantic
     - avoid-accessing-other-classes-private-members
+    - avoid-async-call-in-sync-function
     # - avoid-banned-file-names
     # - avoid-banned-imports
     # - avoid-banned-types
@@ -27,6 +28,7 @@ dart_code_metrics:
     - avoid-declaring-call-method
     - avoid-double-slash-imports
     - avoid-duplicate-exports
+    - avoid-duplicate-mixins
     - avoid-duplicate-named-imports
     - avoid-duplicate-patterns
     - avoid-dynamic
@@ -38,14 +40,15 @@ dart_code_metrics:
     - avoid-generics-shadowing
     - avoid-global-state
     - avoid-ignoring-return-values
-    # - avoid-importing-entrypoint-exports: false # TODO: has false positives in monorepo
+    - avoid-importing-entrypoint-exports
     - avoid-inverted-boolean-checks
     - avoid-keywords-in-wildcard-pattern
     # - avoid-late-keyword
     # - avoid-long-functions # way too pedantic
     # - avoid-long-parameter-list: # way too pedantic
-        # ignore-optional: true # exclude optional and (non-required) named parameters
+    # ignore-optional: true # exclude optional and (non-required) named parameters
     - avoid-long-records
+    - avoid-map-keys-contains
     - avoid-missed-calls
     - avoid-missing-enum-constant-in-map
     - avoid-misused-wildcard-pattern
@@ -65,6 +68,7 @@ dart_code_metrics:
     - avoid-non-null-assertion:
         exclude:
           - test/**
+    - avoid-nullable-interpolation
     - avoid-one-field-records
     - avoid-passing-async-when-sync-expected:
         exclude:
@@ -93,24 +97,28 @@ dart_code_metrics:
     - avoid-unnecessary-futures
     - avoid-unnecessary-negations
     - avoid-unnecessary-nullable-return-type
+    - avoid-unnecessary-reassignment
     - avoid-unnecessary-return
     - avoid-unnecessary-type-assertions
     - avoid-unnecessary-type-casts
     - avoid-unrelated-type-assertions
     - avoid-unrelated-type-casts
     - avoid-unsafe-collection-methods
     - avoid-unused-generics
+    - avoid-unused-instances
     - avoid-unused-parameters
     # - banned-usage
     - binary-expression-operand-order
     - double-literal-format
+    - enum-constants-ordering
     - format-comment:
         only-doc-comments: true
     # - format-test-name # good but painful
     - function-always-returns-null
     - map-keys-ordering:
         exclude:
           - test/**
+    - match-class-name-pattern
     # - match-positional-field-names-on-assignment # not compatible with avoid-redundant-positional-field-name
     - member-ordering:
         order:
@@ -140,6 +148,7 @@ dart_code_metrics:
     - move-records-to-typedefs:
         min-fields: 3
         min-occurrences: 3
+    - newline-before-case
     - newline-before-return
     - no-boolean-literal-compare:
         allow-false: true # allows `variable == false` instead of just `!variable`
@@ -168,8 +177,10 @@ dart_code_metrics:
     - prefer-commenting-analyzer-ignores
     - prefer-conditional-expressions
     # - prefer-correct-error-name # we use `e`
+    - prefer-correct-for-loop-increment
     - prefer-correct-future-return-type
     # - prefer-correct-identifier-length # way too pedantic
+    # - prefer-correct-json-casts # overkill213
     - prefer-correct-stream-return-type
     - prefer-correct-switch-length
     - prefer-correct-test-file-name
@@ -189,7 +200,9 @@ dart_code_metrics:
         allowed-duplicated-chains: 3
         exclude:
           - test/**
+    - prefer-named-boolean-parameters
     - prefer-parentheses-with-if-null
+    - prefer-public-exception-classes
     - prefer-return-await
     # - prefer-returning-conditional-expressions # annoying sometimes
     - prefer-simpler-patterns-null-check
@@ -218,6 +231,7 @@ dart_code_metrics:
     - avoid-inherited-widget-in-initstate
     - avoid-late-context
     - avoid-missing-image-alt
+    - avoid-recursive-widget-calls
     - avoid-returning-widgets
     - avoid-shrink-wrap-in-lists
     - avoid-state-constructors
@@ -237,6 +251,7 @@ dart_code_metrics:
     - prefer-extracting-callbacks
     - prefer-single-widget-per-file:
         ignore-private-widgets: true
+    - prefer-text-rich
     - prefer-using-list-view
     # - prefer-widget-private-members # cannot use this.field in constructor
     - proper-super-calls
@@ -266,3 +281,7 @@ dart_code_metrics:
     ### Intl - not used
 
     ### Angular - not used
+
+    ### Patrol
+    - prefer-custom-finder-over-find
+    - prefer-symbol-over-key

lib/lints.yaml

@@ -16,7 +16,7 @@ analyzer:
     deprecated_member_use_from_same_package: warning
     record_literal_one_positional_no_trailing_comma: error
 
-# version 1.35.0 - https://github.com/dart-lang/linter/blob/main/CHANGELOG.md
+# version 3.1.0 - https://github.com/dart-lang/linter/blob/main/CHANGELOG.md
 linter:
   rules:
     ### ERROR
@@ -45,8 +45,8 @@ linter:
     - no_adjacent_strings_in_list
     - no_duplicate_case_values
     - no_logic_in_create_state
-    # - no_self_assignments # WIP
-    # - no_wildcard_variable_uses # WIP
+    - no_self_assignments
+    - no_wildcard_variable_uses
     # - prefer_relative_imports
     - prefer_void_to_null
     - test_types_in_equals

pubspec.yaml

@@ -1,5 +1,5 @@
 name: netglade_analysis
-version: 3.0.0
+version: 4.0.0
 description: Lint rules for Dart and Flutter used internally at netglade.
 repository: https://github.com/netglade/netglade_analysis
 issue_tracker: https://github.com/netglade/netglade_analysis/issues