Merge pull request #131 from netervati/fix/delete-issue

Handle delete properly in client-side

Author: netervati

components/modal/createApp.vue

@@ -26,7 +26,11 @@
         title: values.title,
       },
       {
-        onSuccess: (key: string) => {
+        onSuccess: (key?: string) => {
+          if (!key) {
+            throw new Error('Key not provided in onSuccess callback.');
+          }
+
           emit('success', key);
           handleClose();
         },

server/routes/apps/[id].delete.ts

@@ -1,9 +1,7 @@
 import AppServices from '~~/server/services/appServices';
 
 export default defineEventHandler(async (event) => {
-  await new AppServices(event).delete(
-    event.context.params?.id ?? ''
-  );
+  await new AppServices(event).delete(event.context.params?.id ?? '');
 
   return null;
 });

server/services/appServices.ts

@@ -20,10 +20,7 @@ export default class AppServices extends SupabaseService {
   }
 
   async delete(id: string) {
-    const apps = await this.client
-      .from('apps')
-      .delete()
-      .eq('id', id);
+    const apps = await this.client.from('apps').delete().eq('id', id);
 
     if (apps.error !== null) {
       throw ErrorResponse.supabase(apps.error);

server/services/modelDataServices.ts

@@ -44,9 +44,9 @@ export default class ModelDataService extends SupabaseService {
 
   async deleteByModelId(modelId: string) {
     return await this.client
-    .from('model_data')
-    .delete()
-    .eq('model_id', modelId);
+      .from('model_data')
+      .delete()
+      .eq('model_id', modelId);
   }
 
   async list(modelId: string) {

stores/useApp.ts

@@ -14,7 +14,7 @@ type UpdateProps = {
 };
 
 type Options = {
-  onSuccess?: (key: string) => void;
+  onSuccess?: (key?: string) => void;
 };
 
 export default defineStore('apps', () => {
@@ -55,11 +55,11 @@ export default defineStore('apps', () => {
     await $fetch(`/apps/${id}`, {
       method: 'DELETE',
       async onResponse({ response }) {
-        if (response.status === 200) {
+        if (response.status === 204) {
           toast.success('Deleted the app!');
 
           if (typeof options.onSuccess === 'function') {
-            options.onSuccess(response._data);
+            options.onSuccess();
           }
 
           await refresh();

stores/useModel.ts

@@ -81,7 +81,7 @@ export default defineStore('models', () => {
       method: 'DELETE',
       query: { apiKey: apiKey.value },
       async onResponse({ response }) {
-        if (response.status === 200) {
+        if (response.status === 204) {
           toast.success('Deleted the model!');
 
           await refresh();

stores/useModelData.ts

@@ -53,7 +53,7 @@ export default defineStore('model-data', () => {
       method: 'DELETE',
       query: { ids, apiKey: apiKey.value },
       async onResponse({ response }) {
-        if (response.status === 200) {
+        if (response.status === 204) {
           toast.success('Deleted the model data!');
 
           await refresh();