Handle delete properly in store

Author: netervati

components/modal/createApp.vue

@@ -26,7 +26,11 @@
         title: values.title,
       },
       {
-        onSuccess: (key: string) => {
+        onSuccess: (key?: string) => {
+          if (!key) {
+            throw new Error('Key not provided in onSuccess callback.');
+          }
+
           emit('success', key);
           handleClose();
         },

stores/useApp.ts

@@ -14,7 +14,7 @@ type UpdateProps = {
 };
 
 type Options = {
-  onSuccess?: (key: string) => void;
+  onSuccess?: (key?: string) => void;
 };
 
 export default defineStore('apps', () => {
@@ -55,11 +55,11 @@ export default defineStore('apps', () => {
     await $fetch(`/apps/${id}`, {
       method: 'DELETE',
       async onResponse({ response }) {
-        if (response.status === 200) {
+        if (response.status === 204) {
           toast.success('Deleted the app!');
 
           if (typeof options.onSuccess === 'function') {
-            options.onSuccess(response._data);
+            options.onSuccess();
           }
 
           await refresh();

stores/useModel.ts

@@ -81,7 +81,7 @@ export default defineStore('models', () => {
       method: 'DELETE',
       query: { apiKey: apiKey.value },
       async onResponse({ response }) {
-        if (response.status === 200) {
+        if (response.status === 204) {
           toast.success('Deleted the model!');
 
           await refresh();

stores/useModelData.ts

@@ -53,7 +53,7 @@ export default defineStore('model-data', () => {
       method: 'DELETE',
       query: { ids, apiKey: apiKey.value },
       async onResponse({ response }) {
-        if (response.status === 200) {
+        if (response.status === 204) {
           toast.success('Deleted the model data!');
 
           await refresh();