Closes #262: Copy migrations table to branch #263
Conversation
There was a problem hiding this comment.
Sorry it took a bit, got myself confused between the new main_schema plugin parameter coming in v0.6.0 with the replaced MAIN_SCHEMA constant and where this was landing relative to that. 🤦
I was verifying that all migrations were copied as part of 0004_copy_migrations and realized that, pretty much by definition, it can't copy itself--so all existing branches that this migration updates will be behind by this single migration. I can't decide if I think that's a problem or not.
Just had one other note to leave yourself a reminder, but looks good otherwise.
| @@ -540,6 +540,29 @@ def provision(self, user): | |||
| f"ALTER TABLE {schema_table} ALTER COLUMN id SET DEFAULT nextval(%s)", [sequence_name] | |||
| ) | |||
|
|
|||
| # Copy the migrations table | |||
| main_table = f'{MAIN_SCHEMA}.django_migrations' | |||
There was a problem hiding this comment.
Might be worth noting this needs to change in v0.6.0, since the other references to MAIN_SCHEMA are already changed in #254.
There was a problem hiding this comment.
Changing this to a 👍 after thinking through
I was verifying that all migrations were copied as part of 0004_copy_migrations and realized that, pretty much by definition, it can't copy itself--so all existing branches that this migration updates will be behind by this single migration. I can't decide if I think that's a problem or not.
Closes: #262
provision()method on Branch to replicate the current state of thedjango_migrationstabledjango_migrationstables to all existing branches