Skip to content

Replace pycodestyle with ruff #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

Replace pycodestyle with ruff #216

merged 3 commits into from
Feb 18, 2025

Conversation

jeremystretch
Copy link
Contributor

  • Swap out pycodestyle with ruff for linting
  • Miscellaneous format cleanup

arthanson
arthanson approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make it ignore migrations/ directory - would be a bit of a pain to have it keep updating new migrations.

@jeremystretch
Copy link
Contributor Author

I'd prefer to keep them in scope as we do for NetBox, to ensure that the auto-generated migrations are wrapped to a reasonable line length for legibility. (These can be formatted automatically by running ruff format migrations/.)

@jeremystretch jeremystretch merged commit 6fd45a6 into main Feb 18, 2025
7 checks passed
@jeremystretch jeremystretch deleted the ruff branch February 18, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthanson arthanson arthanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @arthanson