Fixes #98: Cable changes in branch should not impact main schema #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
approved these changes
Sep 25, 2024
| @@ -21,11 +21,6 @@ def _get_db(self, model, **hints): | |||
| warnings.warn(f"Routing database query for {model} before branching support is initialized.") | |||
| return | |||
|
|
|||
| # Bail if the model does not support branching | |||
There was a problem hiding this comment.
I'm assuming this isn't needed anymore, won't affect plugins and such? Didn't know how to test that.
There was a problem hiding this comment.
Correct; this was originally addressed under #59 but isn't technically needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #98
Replicate the
dcim_cablepathtable when provisioning a branch to ensure cable changes do not interfere with the main schema.