Skip to content

689 documentation #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 23, 2025
Merged

689 documentation #691

merged 15 commits into from
May 23, 2025

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented May 20, 2025

Fixes: #689

Converts to use GitHub Pages for documentation instead of read the docs. Unfortunately GitHub Pages only supports markdown not sphinx so the docs and doc-comments need to be converted.
Monosnap Endpoint - pynetbox 2025-05-20 15-12-56

@arthanson arthanson marked this pull request as ready for review May 20, 2025 22:26
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues I couldn't leave as line comments:

  • Response methods still appear to have ReST syntax docstrings

Sorry about all the ticky-tacky comments--I think that's just the nature of these sort of changes.

@jnovinger
Copy link
Member

I also noticed pynetbox.models.dcim.Devices.napalm() is still a thing. I'll file a bug to remove that.

@arthanson arthanson requested a review from jnovinger May 21, 2025 18:24
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one new thing and couple of existing things that are closer, but not quite there.

@arthanson arthanson merged commit c159a76 into master May 23, 2025
9 checks passed
@jnovinger jnovinger deleted the 689-documentation branch May 23, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read the Docs not getting rebuilt
2 participants