Fix #19910: Add conditional to hide internet dependent links in an isolated deployment #19951
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
requested changes
Jul 25, 2025
| <i title="{% trans "Community" %}" class="mdi mdi-slack text-primary" data-bs-placement="top" data-bs-toggle="tooltip"></i> | ||
| </a> | ||
| </li> | ||
| {% if not settings.ISOLATED_DEPLOYMENT %} |
There was a problem hiding this comment.
Let's combine this {% if not ... %} into the {% else %} above it with {% elif not ... %}. That will allow us to remove the level of indentation that would be necessary otherwise and keep the template more readable.
| @@ -184,7 +184,7 @@ <h1 class="navbar-brand pb-0"> | |||
| {% endif %} | |||
|
|
|||
| {# Commercial links #} | |||
| {% if settings.RELEASE.features.commercial %} | |||
| {% if settings.RELEASE.features.commercial and not settings.ISOLATED_DEPLOYMENT %} | |||
There was a problem hiding this comment.
These might be mutually exclusive, but I'm not positive. I'm checking now and will have an answer for you ASAP.
Never mind on this one, I was incorrect and your approach is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19910
In the base template, add conditionals on internet links to hide them when the setting ISOLATED_DEPLOYMENT is set to True.