Skip to content

Closes #261 - Add support for NetBox v4.3 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

pheus
Copy link
Contributor

@pheus pheus commented May 23, 2025

Pull Request

Related Issue

Closes #261 - [Housekeeping]: Add support for NetBox v4.3

New Behavior

This PR updates the NetBox ACL plugin to be compatible with NetBox version 4.3. It reorganizes the GraphQL filter definitions into a modular structure to align with the breaking changes introduced in the latest NetBox GraphQL schema.

Contrast to Current Behavior

Previously, the plugin was built to support NetBox versions before 4.3. The changes in NetBox v4.3, especially within the GraphQL filtering framework, rendered the plugin incompatible. This update ensures continued functionality with the latest NetBox version.

Discussion: Benefits and Drawbacks

Benefits:

  • Maintains plugin compatibility with the latest NetBox release (v4.3).
  • Modular GraphQL filter structure improves maintainability and readability.
  • Enables users to upgrade NetBox without losing ACL plugin functionality.

Drawbacks:

  • This update is not backward-compatible with versions of NetBox prior to 4.3 due to the breaking changes introduced upstream.

Changes to the Documentation

  • Version requirements in the plugin documentation should be updated to indicate support for NetBox v4.3+ only.

Proposed Release Note Entry

  • BREAKING CHANGE: Updated GraphQL filter logic to support NetBox v4.3. This release is not compatible with earlier NetBox versions. Users must upgrade to NetBox 4.3 or higher.

Double Check

  • I have explained my PR according to the information in the comments
    or in a linked issue.
  • My PR targets the dev branch.

pheus added 2 commits May 23, 2025 22:09
Reorganized GraphQL filter definitions into a modular structure with
clear folder separation. This change was required to maintain
compatibility with NetBox v4.3, which introduced breaking changes to the
GraphQL filtering framework.

BREAKING CHANGE: Requires NetBox version 4.3
Bumps the NetBox base image version from v4.2 to v4.3. Ensures the
plugin remains compatible with the updated NetBox version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping]: Add support for NetBox v4.3
1 participant