Skip to content

fix: nb_lookup plugin: Allow mac-addresses lookup #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

shaderecker
Copy link

Related Issue

New Behavior

Add possibility to query mac-addresses with the nb_lookup plugin for NetBox 4.2+

...

Contrast to Current Behavior

Feature is missing so far

...

Discussion: Benefits and Drawbacks

  • mac-addresses was added in Netbox 4.2 so we need to follow the feature set
  • No drawbacks
  • The mac-addresses feature wasn't available in Netbox versions lower than 4.2 so it won't impact those.

...

Changes to the Documentation

n/a

...

Proposed Release Note Entry

nb_lookup plugin - Allow mac-addresses lookup

...

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

Copy link
Contributor

@sc68cal sc68cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to check the API version before adding to netbox_endpoint_map - because we still support 4.1 where this API is not available.

There are lots of examples of this, below the line that you have added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants