Updated netbox_circuit_termination.py to support NetBox 4.2.x #1402
Conversation
…ermination_type requirements from NetBox 4.2.0 release
|
This needs to be done in a way that preserves backwards compatibility with older NetBox versions since we still use those for CI tests, and we have by convention supported the two most recent releases, which at this point would be |
Thanks for the feedback, @sc68cal. I just pushed new changes that preserve backward compatibility and prevent parameter overlap between the params required for versions pre-4.2.0 and those for versions 4.2.0 and later. The fix was tested against NetBox Cloud running 4.1.11 as well as 4.2.5. |
|
Looks good, just some small style changes for |
|
Doc build failure appears unrelated to your changes. |
…-community#1402) * updated netbox_circuit_termination.py to support termination_id and termination_type requirements from NetBox 4.2.0 release * fixed typo in documentation * added backward compatibility with NetBox versions before 4.2.0 * black formatting and changelog fragement * fixed doc-choices-do-not-match-spec CI failure * fixed line length failure from CI checks --------- Co-authored-by: Nick Thompson <13121431+nsthompson@users.noreply.github.com>
…-community#1402) * updated netbox_circuit_termination.py to support termination_id and termination_type requirements from NetBox 4.2.0 release * fixed typo in documentation * added backward compatibility with NetBox versions before 4.2.0 * black formatting and changelog fragement * fixed doc-choices-do-not-match-spec CI failure * fixed line length failure from CI checks --------- Co-authored-by: Nick Thompson <13121431+nsthompson@users.noreply.github.com>
Related Issue
#1401
New Behavior
This fix is to resolve the changes created by the NetBox 4.2.0 release relating to:
The site and provider_network foreign key fields on circuits.CircuitTermination have been replaced by the termination generic foreign key.Contrast to Current Behavior
Current behavior results in module failure with the error:
A circuit termination must attach to a terminating object.Discussion: Benefits and Drawbacks
This fix resolves the issue with NetBox 4.2.x. It is backward compatible with prior versions.
Changes to the Documentation
Documentation in the module has been updated.
Proposed Release Note Entry
Updated netbox_circuit_termination.py to support NetBox 4.2.x breaking changes.
Double Check
develbranch.