fix(microservices): Revisit RMQ pattern matching with wildcards #15305
+169
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #15304
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 15304
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Before starting I asked myself, what would be the best approach?
Option 1: Keep Current Regex but Make it Safer
Tradeoffs:
Option 2: Use Map and Nested For Loop same as SeerverMQTT
Based on MQTT approach (matchMqttPattern in server-mqtt.ts:180-210):
Tradeoffs:
Option 3: Use Trie to store patterns and handlers (such as https://github.com/davedoesdev/qlobber)
Based on qlobber library:
Tradeoffs:
I went with option 2: it seems more reasonable.